fix handling of artefact name#352
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since build jobs can create tarballs using other compression tools such as
zstdwhich result in different suffixes than.gzthe bot's deploy code does not work correctly. Initially all information is correctly taken from a job's result file (named_bot_jobJOBID.result), but in subsequent processing part of the information is dropped and a hardcoded suffix (.tar.gz) is used.This PR just uses the full name of the artefact as provided by the
*.resultfile.Note, this is a hot fix. There may be other issues with the processing of artefact names (e.g., if the suffix is just
.tarwithout any.gzor.zstd). Also, the timestamp that was previously used to recreate the full name of the tarball to be uploaded is not used any longer it seems (maybe the hound will complain).